Epilogue DataType Mismatch #563
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitchawla1
force-pushed
the
dev/achawla/cutlass_252
branch
from
c39f4ba to
a391e80
Compare
|
@amitchawla1 I think this issue is already addressed by #482. |
|
Please explain in the PR description why the PR is fixing it the way it is (and not some other way e.g. #482). |
Antonyvance
changed the title
Antonyvance
added
bug
Signed-off-by: Chawla, Amit K <[email protected]>
amitchawla1
force-pushed
the
dev/achawla/cutlass_252
branch
from
a391e80 to
bf1764c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CollectiveBuilder takes ElementAccumulator, ElementCompute and ElementC as template input.
In test case, these datatypes are float, float and half_t.
Current code assumes all to be same (initiated with accumulator dtype), leading to datatype related assert in Copy.
This PR passes correct dataype for ElementC, ElementCompute is taken from FusionCallbacks operation and ElementAccumulator from ElementCompute.